Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 )
Change subject: IMPALA-6694: fix "buffer pool" child profile order ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9749/3/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/9749/3/be/src/util/runtime-profile.cc@358 PS3, Line 358: insert_pos != children_.end() > * The reason calling from multiple threads might cause problems is that the After looking at the profile in the Jira more I'm not sure anymore that I understand the bug. In the profile in the Jira there should be children for each exec node. Each has its own buffer pool profile inside its own children_ list. I don't understand how they can become interleaved between each other when the exchange nodes should be the owners. Can you help me understand what I'm missing? I'll sleep over it and will have a look again tomorrow. -- To view, visit http://gerrit.cloudera.org:8080/9749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I230f0673edf20a846fdb13191b7a292d329c1bb8 Gerrit-Change-Number: 9749 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Mar 2018 06:29:51 +0000 Gerrit-HasComments: Yes
