Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 )
Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements ...................................................................... Patch Set 7: (3 comments) Patch lgtm. I can +1 once my comments are addressed. http://gerrit.cloudera.org:8080/#/c/9800/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9800/7//COMMIT_MSG@7 PS7, Line 7: Incorrect exception handling in create/drop function statements I think the more accurate title would be to allow add/drop of functions with the same name as built-ins? http://gerrit.cloudera.org:8080/#/c/9800/7//COMMIT_MSG@61 PS7, Line 61: DLL DDL? http://gerrit.cloudera.org:8080/#/c/9800/7/testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test File testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test: http://gerrit.cloudera.org:8080/#/c/9800/7/testdata/workloads/functional-query/queries/QueryTest/functions-ddl.test@302 PS7, Line 302: ==== Can you add SHOW functions in $DATABASE after create and drop for these tests? -- To view, visit http://gerrit.cloudera.org:8080/9800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa Gerrit-Change-Number: 9800 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 28 Mar 2018 20:26:08 +0000 Gerrit-HasComments: Yes
