Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 )
Change subject: IMPALA-6724: Allow creating/dropping functions with the same name as built-ins ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/9800/15/fe/src/main/java/org/apache/impala/analysis/FunctionName.java File fe/src/main/java/org/apache/impala/analysis/FunctionName.java: http://gerrit.cloudera.org:8080/#/c/9800/15/fe/src/main/java/org/apache/impala/analysis/FunctionName.java@122 PS15, Line 122: isBuiltin_ = db_.equals(Catalog.BUILTINS_DB) && builtinDb.containsFunction(fn_); db_ may not be set correctly here, you need to do this after the if/else I had this simpler code in mind: Db builtinDb = analyzer.getCatalog().getBuiltinsDb(); if (!isFullyQualified()) { db_ = analyzer.getDefaultDb(); if (preferBuiltinsDb && builtinDb.containsFunction(fn_)) { db_ = Catalog.BUILTINS_DB; } } isBuiltin_ = db_.equals(Catalog.BUILTINS_DB) && builtinDb.containsFunction(fn_); -- To view, visit http://gerrit.cloudera.org:8080/9800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa Gerrit-Change-Number: 9800 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 17:42:08 +0000 Gerrit-HasComments: Yes
