Fredy Wijaya has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/9819 )
Change subject: IMPALA-6739: Exception in ALTER TABLE SET statements ...................................................................... IMPALA-6739: Exception in ALTER TABLE SET statements The patch fixes issues with executing ALTER TABLE SET statements when there are no matching partitions. The patch also removes incorrect precondition i.e. (partitionSet == null || !partitionSet.isEmpty()) in ALTER TABLE SET statements because a partitionSet can be null when PARTITION is not specified in the ALTER TABLE SET statement and partitionSet can be empty when there is no matching partition. For example: Matching partitions (partitionSet != null && !partitionSet.isEmpty()): > alter table functional.alltypesagg partition(year=2009, month=1) set fileformat parquet; No matching partitions (partitionSet != null && partitionSet.isEmpty()): > alter table functional.alltypesagg partition(year=2009, month=1) set fileformat parquet; No partition specified (partitionSet == null): > alter table functional.alltypesagg set fileformat parquet; Testing: - Added a new test - Ran all front-end tests Change-Id: I793e827d5cf5b7986bd150dd9706df58da3417f3 --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-all-fs.test 4 files changed, 68 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/9819/12 -- To view, visit http://gerrit.cloudera.org:8080/9819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I793e827d5cf5b7986bd150dd9706df58da3417f3 Gerrit-Change-Number: 9819 Gerrit-PatchSet: 12 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
