Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9901 )
Change subject: IMPALA-6791: distcc server setup script ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh File bin/distcc/distcc_server_setup.sh: http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh@54 PS2, Line 54: echo "This script only supports Ubuntu" >&2 > This seems untrue given line 49-52 Done http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh@76 PS2, Line 76: ALLOWED_NETS=${ALLOWED_NETS:-172.16.0.0/12} > This one seems weird to have a default for. Yeah, I guess so. I convinced myself that it sort-of made sense since it was a common private network, but that still doesn't really make sense. I changed it to be a required argument. http://gerrit.cloudera.org:8080/#/c/9901/2/bin/distcc/distcc_server_setup.sh@83 PS2, Line 83: # CCACHE_DIR is picked up by ccache from environment. > Does this work on reboot? I'm surprised this doesn't need to be in /etc/def This line is inside a string that is appended to /etc/default/distcc (it's within the EOF delimiters). I also realised that it would be useful to include some comments in the config files stating where they came from. -- To view, visit http://gerrit.cloudera.org:8080/9901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a145911f095eb8e173694475cc2dac65eb7c7bb Gerrit-Change-Number: 9901 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 03 Apr 2018 22:08:42 +0000 Gerrit-HasComments: Yes
