Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 )
Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 ...................................................................... Patch Set 1: > We also have the source code for sqlparse checked into the repo for > the shell. Should we also upgrade that version? The argument for > that is that it will minimise divergence between the shell's > behaviour and our test's behaviour. Looking through the tests, I don't think our tests actually use sqlparse. The only python file that includes sqlparse is tests/comparison/model_translator.py. It uses it for pretty printing SQL. As far as I can tell, nothing uses that pretty printing. Dataload uses sqlparse as a glorified split on ';', so we could also just stop using it there. -- To view, visit http://gerrit.cloudera.org:8080/10044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5289f86b78f1d77d91a8fa47d63b7a7eaa3af38 Gerrit-Change-Number: 10044 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Apr 2018 17:18:57 +0000 Gerrit-HasComments: No
