Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 )
Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 ...................................................................... Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/9300/11/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9300/11/CMakeLists.txt@159 PS11, Line 159: 1.0.1 Is the plan to also cherry-pick the change to 2.x branch ? I believe there may be more complication downstream if that's the plan. http://gerrit.cloudera.org:8080/#/c/9300/11/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/9300/11/be/src/common/init.cc@240 PS11, Line 240: signal(SIGPIPE, SIG_IGN); Why is this suddenly needed as part of the upgrade to thrift 0.9.3 ? http://gerrit.cloudera.org:8080/#/c/9300/11/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/9300/11/be/src/rpc/thrift-server-test.cc@362 PS11, Line 362: {TLSv1_1, {SSLTLS, TLSv1_1}}, Should this also include TLSv1_0 ? http://gerrit.cloudera.org:8080/#/c/9300/11/be/src/rpc/thrift-server-test.cc@363 PS11, Line 363: {TLSv1_2, {SSLTLS, TLSv1_2}}}; Should this also include TLSv1_0 and TLSv1_1 ? http://gerrit.cloudera.org:8080/#/c/9300/11/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9300/11/common/thrift/CMakeLists.txt@68 PS11, Line 68: "ImpalaService.thrift" So, is the generated java file of ImpalaService.thrift not needed in the FE all along ? -- To view, visit http://gerrit.cloudera.org:8080/9300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6 Gerrit-Change-Number: 9300 Gerrit-PatchSet: 11 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Apr 2018 19:31:07 +0000 Gerrit-HasComments: Yes
