Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10108 )
Change subject: IMPALA-6878: SentryServicePinger should not print stacktrace at every retry ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10108/1/fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java File fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java: http://gerrit.cloudera.org:8080/#/c/10108/1/fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java@41 PS1, Line 41: static { I think you should do this in main(). In the off-chance that someone happens to load SentryServicePinger.class in some test for some reason, they'll end up with logging off. -- To view, visit http://gerrit.cloudera.org:8080/10108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26f9a141c89692443cb3cdcb6bf62581a93b5ba0 Gerrit-Change-Number: 10108 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 00:00:24 +0000 Gerrit-HasComments: Yes
