Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10132 )
Change subject: IMPALA-6896: NullPointerException in DESCRIBE FORMATTED on views ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/10132/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10132/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1916 PS2, Line 1916: if (params.isSetComment() && params.getComment() != null) { extra space after && http://gerrit.cloudera.org:8080/#/c/10132/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1935 PS2, Line 1935: view.setDbName(params.getView_name().getDb_name()); name and db is expected to be set right? http://gerrit.cloudera.org:8080/#/c/10132/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1937 PS2, Line 1937: if (params.isSetComment() && params.getComment() != null) { extra space after && http://gerrit.cloudera.org:8080/#/c/10132/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1940 PS2, Line 1940: StorageDescriptor sd = view.getSd(); combine with L1942 http://gerrit.cloudera.org:8080/#/c/10132/2/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/10132/2/tests/metadata/test_ddl.py@366 PS2, Line 366: # IMPALA-6896: NPE in describe formatted on views. The message should describe what is being tested, and not just have the JIRA title. For example: Tests that altered views can be described by all impalads. http://gerrit.cloudera.org:8080/#/c/10132/2/tests/metadata/test_ddl.py@379 PS2, Line 379: time.sleep(5) Instead of sleeping, let's run the loop below until we find "alltypesagg" in the output of all the describes -- To view, visit http://gerrit.cloudera.org:8080/10132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica2fb0c4f4b09cdf36eeb4911a1cbe7e98381d9e Gerrit-Change-Number: 10132 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Apr 2018 05:27:52 +0000 Gerrit-HasComments: Yes
