Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9168 )
Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types ...................................................................... IMPALA-5690: Part 1: Rename ostream operators for thrift types Thrift 0.9.3 implements "ostream& operator<<(ostream&, T)" for thrift data types while impala did the same to enums and special types including TNetworkAddress and TUniqueId. To prepare for the upgrade of thrift 0.9.3, this patch renames these impala defined functions. In the absence of operator<<, assertion macros like DCHECK_EQ can no longer be used on non-enum thrift defined types. Change-Id: I9c303997411237e988ef960157f781776f6fcb60 Reviewed-on: http://gerrit.cloudera.org:8080/9168 Reviewed-by: Tianyi Wang <tw...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/benchmarks/scheduler-benchmark.cc M be/src/codegen/llvm-codegen.cc M be/src/exec/exchange-node.cc M be/src/exec/exec-node.cc M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node.cc M be/src/exec/parquet-column-readers.cc M be/src/exec/parquet-metadata-utils.cc M be/src/rpc/rpc-trace.cc M be/src/rpc/thrift-client.cc M be/src/rpc/thrift-util.cc M be/src/rpc/thrift-util.h M be/src/runtime/client-cache.cc M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator.cc M be/src/runtime/data-stream-mgr.cc M be/src/runtime/data-stream-recvr.cc M be/src/runtime/data-stream-sender.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/krpc-data-stream-mgr.cc M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-sender.cc M be/src/runtime/mem-tracker.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-state.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-state.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/scheduler.cc M be/src/service/child-query.cc M be/src/service/client-request-state.cc M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-internal-service.cc M be/src/service/impala-server.cc M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-result-set.cc M be/src/statestore/statestore.cc M be/src/util/collection-metrics.h M be/src/util/debug-util.cc M be/src/util/debug-util.h M be/src/util/histogram-metric.h M be/src/util/metrics.h M be/src/util/network-util.cc M be/src/util/network-util.h M be/src/util/webserver.cc M testdata/workloads/functional-query/queries/QueryTest/set.test M tests/shell/test_shell_commandline.py 50 files changed, 278 insertions(+), 290 deletions(-) Approvals: Tianyi Wang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9c303997411237e988ef960157f781776f6fcb60 Gerrit-Change-Number: 9168 Gerrit-PatchSet: 16 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
