Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10129 )
Change subject: thrift-0.9.3-p4: forward compatibility of TLS protocols ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Please have Sailesh take a look too. http://gerrit.cloudera.org:8080/#/c/10129/1/source/thrift/thrift-0.9.3-patches/0004-TLS-forward-compatibility.patch File source/thrift/thrift-0.9.3-patches/0004-TLS-forward-compatibility.patch: http://gerrit.cloudera.org:8080/#/c/10129/1/source/thrift/thrift-0.9.3-patches/0004-TLS-forward-compatibility.patch@33 PS1, Line 33: + break; May wanna include "protocol" in the exception string. -- To view, visit http://gerrit.cloudera.org:8080/10129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdca94a9426feff5ab52a80cf4da669a3fbfe812 Gerrit-Change-Number: 10129 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Apr 2018 20:57:08 +0000 Gerrit-HasComments: Yes