Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20485 )
Change subject: IMPALA-10949: Improve batching logic of partition events ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20485/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20485/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@741 PS2, Line 741: Newer the name doesn't match the semantics, the function returns true if the event's event id is NOT newer than lastSyncedEventId http://gerrit.cloudera.org:8080/#/c/20485/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@747 PS2, Line 747: catch Exception handling could be skipped by using getTableNoThrow instead of getTable. It returns null if the db or table is not found. -- To view, visit http://gerrit.cloudera.org:8080/20485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e79510739347cbe669719a9e4cb9cabd5daa7d3 Gerrit-Change-Number: 20485 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Dec 2023 09:06:55 +0000 Gerrit-HasComments: Yes
