Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10119 )
Change subject: IMPALA-6821: Push down limits into Kudu ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10119/3/testdata/workloads/functional-query/queries/QueryTest/kudu_limit.test File testdata/workloads/functional-query/queries/QueryTest/kudu_limit.test: http://gerrit.cloudera.org:8080/#/c/10119/3/testdata/workloads/functional-query/queries/QueryTest/kudu_limit.test@11 PS3, Line 11: select * from functional_kudu.alltypes order by id limit 2 Order by limit means there is no limit on the scan node - I don't think that's what we want to test. We want to test limits on the Kudu scan node with and without predicates. -- To view, visit http://gerrit.cloudera.org:8080/10119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe35e70065d8706b575e24fe20902cd405b49941 Gerrit-Change-Number: 10119 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Apr 2018 18:05:52 +0000 Gerrit-HasComments: Yes
