Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20786 )
Change subject: IMPALA-12584: Add backend config to restrict data file locations for Iceberg tables ...................................................................... Patch Set 3: (6 comments) I've mostly found nitpicks, otherwise the change looks good! http://gerrit.cloudera.org:8080/#/c/20786/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20786/3//COMMIT_MSG@10 PS3, Line 10: when one of : the data files nit: "when at least one data file", or "if any data files are outside" http://gerrit.cloudera.org:8080/#/c/20786/3/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/20786/3/be/src/common/global-flags.cc@418 PS3, Line 418: " add space http://gerrit.cloudera.org:8080/#/c/20786/3/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/20786/3/common/thrift/BackendGflags.thrift@268 PS3, Line 268: 118: required bool iceberg_restrict_data_file_location Please add this to the end of the list, otherwise it might make it hard to backport http://gerrit.cloudera.org:8080/#/c/20786/3/tests/custom_cluster/test_iceberg_strict_data.py File tests/custom_cluster/test_iceberg_strict_data.py: http://gerrit.cloudera.org:8080/#/c/20786/3/tests/custom_cluster/test_iceberg_strict_data.py@31 PS3, Line 31: nit: redundant space http://gerrit.cloudera.org:8080/#/c/20786/3/tests/custom_cluster/test_iceberg_strict_data.py@40 PS3, Line 40: failed nit: "will fail" http://gerrit.cloudera.org:8080/#/c/20786/3/tests/custom_cluster/test_iceberg_strict_data.py@50 PS3, Line 50: the tables successfully loads nit: "the tables load successfully." -- To view, visit http://gerrit.cloudera.org:8080/20786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60e3d93b5039dc977417e7b097b3d6ddeda52de4 Gerrit-Change-Number: 20786 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Dec 2023 12:56:21 +0000 Gerrit-HasComments: Yes
