Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20506 )

Change subject: IMPALA-12465: Unicode column name support
......................................................................


Patch Set 24: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20506/23/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/20506/23/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@450
PS23, Line 450: .
> Nit: now it's only one name.
Done


http://gerrit.cloudera.org:8080/#/c/20506/23/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@522
PS23, Line 522: .
> Nit: now it's only one name.
Done



--
To view, visit http://gerrit.cloudera.org:8080/20506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718
Gerrit-Change-Number: 20506
Gerrit-PatchSet: 24
Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Dec 2023 21:55:43 +0000
Gerrit-HasComments: Yes

Reply via email to