Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20809 )
Change subject: IMPALA-12380 WIP ...................................................................... Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java: http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@44 PS1, Line 44: private static final Logger LOGGER = LoggerFactory.getLogger(JdbcStorageConfigManager.class); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@64 PS1, Line 64: public static String getPasswordFromProperties(Properties properties, Function<String, String> keyTransform) line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@65 PS1, Line 65: // throws IOException line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@71 PS1, Line 71: // In tez, when the job conf is copied there is a code path in HiveInputFormat where all the table properties line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@72 PS1, Line 72: // are copied and the password is copied from the job credentials, so its possible to have 2 of them set. line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@73 PS1, Line 73: // For now ignore this and print a warning message, we should fix so that the above code is used instead. line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@74 PS1, Line 74: LOGGER.warn("Only one of " + CONFIG_PWD + ", " + CONFIG_PWD_KEYSTORE + ", " + CONFIG_PWD_URI + " can be set"); line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@76 PS1, Line 76: // "Only one of " + CONFIG_PWD + ", " + CONFIG_PWD_KEYSTORE + ", " + CONFIG_PWD_URI + " can be set"); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@90 PS1, Line 90: // Should I include the uri in the exception? Suppressing for now, since it may have sensitive info. line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@109 PS1, Line 109: public static String getPasswdFromKeystore(String keystore, String key) throws IOException { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@122 PS1, Line 122: public static String getPasswdFromUri(String uriString) throws IOException, URISyntaxException { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/SecretSource.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/SecretSource.java: http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/SecretSource.java@26 PS1, Line 26: * The URI scheme is used to match an URI to an implementation scheme. The implementations are discovered and loaded line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/SecretSource.java@27 PS1, Line 27: * using java service loader. Currently, there isn't a way to initialize or reset a SecretSource after construction. line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/URISecretSource.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/URISecretSource.java: http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/URISecretSource.java@30 PS1, Line 30: * Class provides a way to load passwords using a URI. The secret sources are discovered using java service loader. line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/URISecretSource.java@60 PS1, Line 60: throw new RuntimeException("Two sources for same scheme: " + source.getURIScheme() + " [" + line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/testdata/bin/copy-ext-data-sources.sh File testdata/bin/copy-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/20809/1/testdata/bin/copy-ext-data-sources.sh@59 PS1, Line 59: hadoop credential create hiveruser -provider jceks://hdfs/test-warehouse/data-sources/test.jceks -v password line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/20809/1/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/20809/1/tests/custom_cluster/test_ext_data_sources.py@125 PS1, Line 125: a flake8: E501 line too long (98 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/20809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec83a9b6e00456f0a1bbee747bd752b2cf9bf238 Gerrit-Change-Number: 20809 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sat, 16 Dec 2023 00:58:46 +0000 Gerrit-HasComments: Yes
