Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20367 )
Change subject: IMPALA-10976: Sync db/table to latest HMS event for all DDL/DMLs ...................................................................... Patch Set 17: (5 comments) http://gerrit.cloudera.org:8080/#/c/20367/16/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/20367/16/fe/src/main/java/org/apache/impala/catalog/Table.java@1073 PS16, Line 1073: lastRefreshEventId_ = eventId; > 'lastRefreshEventId_' is also used in skipping events: Yeah, we have taken care of all the events that fire the event, so this shouldn't be an issue. Infact, We skip older events based on lastRefreshEventId when event_sync_to_latest_ddl to false even today. Also, we are gonna are remove all these fields i.e, lastSyncEventId and lastRefreshEventId etc., and combine them into one single field after this patch. I think we are good. http://gerrit.cloudera.org:8080/#/c/20367/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20367/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2629 PS16, Line 2629: up-to-date, > nit: "up-to-date" Ack http://gerrit.cloudera.org:8080/#/c/20367/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3210 PS16, Line 3210: addCatalogServiceIdentifiers(table, catalog_.getCatalogServiceId(), : newCatalogVersion); : TblTransaction tblTxn = MetastoreShim.createTblTransaction(hmsClient, : table.getMetaStoreTable(), txn.getId()); > I think we can reuse this when syncToLatestEventOnDdls is turned on. It gen Ack http://gerrit.cloudera.org:8080/#/c/20367/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3297 PS16, Line 3297: addCatalogServiceIdentifiers(table, catalog_.getCatalogServiceId(), > Will this generate HMS events? Nope. this is not generating any event. http://gerrit.cloudera.org:8080/#/c/20367/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3322 PS16, Line 3322: newCatalogVersion); : HdfsTable hdfsTable = (HdfsTable) table; : boolean isTableBeingReplicated = false; : Stopwatch sw = Stopwatch.createStarted(); : try { > Same here. I think we can reuse this when syncToLatestEventOnDdls is turned Ack -- To view, visit http://gerrit.cloudera.org:8080/20367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf Gerrit-Change-Number: 20367 Gerrit-PatchSet: 17 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Sun, 17 Dec 2023 19:14:09 +0000 Gerrit-HasComments: Yes
