Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20810 )
Change subject: WIP: Skip KRPC in local exchanges ...................................................................... Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-recvr.cc@341 PS4, Line 341: if (payload->rpc_context != nullptr) TRACE_TO(payload->rpc_context->trace(), "Enqueuing deferred RPC"); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-recvr.cc@491 PS4, Line 491: //TRACE_TO(rpc_context->trace(), "Failed to deserialize batch: $0", status.GetDetail()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-recvr.cc@645 PS4, Line 645: if (ctx->rpc_context != nullptr) TRACE_TO(ctx->rpc_context->trace(), "Batch queue is full"); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-recvr.cc@668 PS4, Line 668: if (ctx->rpc_context != nullptr) recvr_->deferred_rpc_tracker()->Release(ctx->rpc_context->GetTransferSize()); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-recvr.cc@673 PS4, Line 673: if (ctx->rpc_context != nullptr) DataStreamService::RespondRpc(status, ctx->response, ctx->rpc_context); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/krpc-data-stream-sender.cc@691 PS4, Line 691: RETURN_IF_ERROR(parent_->SerializeBatch(batch, serialization_batch->get(), !is_local_)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/local-row-batch-channel.h File be/src/runtime/local-row-batch-channel.h: http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/local-row-batch-channel.h@38 PS4, Line 38: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/local-row-batch-channel.cc File be/src/runtime/local-row-batch-channel.cc: http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/local-row-batch-channel.cc@50 PS4, Line 50: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/local-row-batch-channel.cc@97 PS4, Line 97: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/local-row-batch-channel.cc@162 PS4, Line 162: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/4/be/src/runtime/local-row-batch-channel.cc@171 PS4, Line 171: Status LocalRowBatchChannelManager::RegisterSender(RuntimeState* state, line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee16cd943d76d04874bce7f3959e74b4685adb6e Gerrit-Change-Number: 20810 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 17 Dec 2023 23:13:11 +0000 Gerrit-HasComments: Yes
