Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Remove DCHECK for slow SetQueryInflight ...................................................................... IMPALA-12633: Remove DCHECK for slow SetQueryInflight Removes the DCHECK that the original query is inflight before trying to close it during a query retry. SetQueryInflight is a separate operation the server performs after a query has started executing async, and it's possible for the query to fail and retry before the server calls SetQueryInflight. When that happens, we still need to perform cleanup or the original request_state is never closed and we hit a different DCHECK: "BlockOnWait() needs to be called!" Adds an option to CloseClientRequestState for when we close a ClientRequestState but the query is retrying with a new state. It ensures that we bypass most of SetQueryInflight in case CloseClientRequestState was called first. Updates the message from DCHECK in ClientRequestState's destructor to reflect that wait_thread_ is only reset in Finalize. Adds a debug action and test where just the original query is delayed during the SetQueryInflight call. Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Reviewed-on: http://gerrit.cloudera.org:8080/20799 Reviewed-by: Riza Suminto <riza.sumi...@cloudera.com> Reviewed-by: Wenzhe Zhou <wz...@cloudera.com> Reviewed-by: Quanlong Huang <huangquanl...@gmail.com> Tested-by: Michael Smith <michael.sm...@cloudera.com> --- M be/src/runtime/query-driver.cc M be/src/service/client-request-state.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M tests/custom_cluster/test_query_retries.py 5 files changed, 99 insertions(+), 11 deletions(-) Approvals: Riza Suminto: Looks good to me, but someone else must approve Wenzhe Zhou: Looks good to me, approved Quanlong Huang: Looks good to me, approved Michael Smith: Verified -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
