Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )
Change subject: IMPALA-12375: Make DataSource Object persistent ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java File fe/src/main/java/org/apache/impala/catalog/DataSource.java: http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@20 PS4, Line 20: import org.apache.impala.thrift.TCatalogObject; > This class doesn't exist in Apache Hive 3.1. We need to move some codes int Thanks to catch this issue. Move all DataConnector related code to MetastoreShim of CDP Hive in fe/src/compat-hive-3/ http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@100 PS4, Line 100: : : > nit: remove the else-branch and "return null" directly. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/20768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab Gerrit-Change-Number: 20768 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 01 Jan 2024 22:55:16 +0000 Gerrit-HasComments: Yes
