k.venureddy2...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20486 )
Change subject: IMPALA-12356: Fix first ALTER_PARTITION event from Hive could be treated as self event ...................................................................... Patch Set 14: (3 comments) Fixed review comments http://gerrit.cloudera.org:8080/#/c/20486/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20486/11//COMMIT_MSG@7 PS11, Line 7: IMPALA-12356: Fix first ALTER_PARTITION event from Hive could be : treated as self event : > nit: this might be too long. We can put this in the commit message body and Done http://gerrit.cloudera.org:8080/#/c/20486/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20486/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6914 PS11, Line 6914: Lists.newArrayList(); > nit: could you add a comment here mentioning self-event detection is deprec Done http://gerrit.cloudera.org:8080/#/c/20486/11/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/20486/11/tests/metadata/test_event_processing.py@440 PS11, Line 440: def test_partition_location_change_from_hive(self, unique_database): > It'd be nice to also add test coverage on transactional tables. Impala can Done -- To view, visit http://gerrit.cloudera.org:8080/20486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3 Gerrit-Change-Number: 20486 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Jan 2024 06:22:13 +0000 Gerrit-HasComments: Yes
