Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20367 )

Change subject: IMPALA-10976: Sync db/table to latest HMS event for all DDL/DMLs
......................................................................


Patch Set 22:

(35 comments)

http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py
File tests/custom_cluster/test_sync_to_latest_hms_events.py:

http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@19
PS22, Line 19: from builtins import map, range
flake8: F401 'builtins.range' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@19
PS22, Line 19: from builtins import map, range
flake8: F401 'builtins.map' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@21
PS22, Line 21: import re
flake8: F401 're' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@22
PS22, Line 22: import time
flake8: F401 'time' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@25
PS22, Line 25: from tests.common.environ import (HIVE_MAJOR_VERSION)
flake8: F401 'tests.common.environ.HIVE_MAJOR_VERSION' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@26
PS22, Line 26: from tests.common.impala_test_suite import (LOG, ImpalaTestSuite)
flake8: F401 'tests.common.impala_test_suite.LOG' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@31
PS22, Line 31: from tests.util.event_processor_utils import EventProcessorUtils
flake8: F401 'tests.util.event_processor_utils.EventProcessorUtils' imported 
but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@32
PS22, Line 32: from tests.util.filesystem_utils import (
flake8: F401 'tests.util.filesystem_utils.IS_ADLS' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@32
PS22, Line 32: from tests.util.filesystem_utils import (
flake8: F401 'tests.util.filesystem_utils.IS_S3' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@47
PS22, Line 47: class_instance = TestDdlStatements()
flake8: E305 expected 2 blank lines after class or function definition, found 1


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/custom_cluster/test_sync_to_latest_hms_events.py@49
PS22, Line 49: class TestSyncToLatestHmsEvents(CustomClusterTestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@153
PS22, Line 153: t
flake8: F821 undefined name 'test_truncate_cleans_hdfs_files'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@156
PS22, Line 156: @
flake8: F811 redefinition of unused 'test_truncate_cleans_hdfs_files' from line 
150


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@250
PS22, Line 250: t
flake8: F821 undefined name 'test_metadata_after_alter_database'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@252
PS22, Line 252: @
flake8: F811 redefinition of unused 'test_metadata_after_alter_database' from 
line 249


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@268
PS22, Line 268: t
flake8: F821 undefined name 'test_alter_table_set_owner'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@270
PS22, Line 270: @
flake8: F811 redefinition of unused 'test_alter_table_set_owner' from line 267


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@284
PS22, Line 284: t
flake8: F821 undefined name 'test_alter_view_set_owner'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@286
PS22, Line 286: @
flake8: F811 redefinition of unused 'test_alter_view_set_owner' from line 283


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@495
PS22, Line 495: t
flake8: F821 undefined name 'test_drop_partition_with_purge'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@498
PS22, Line 498: @
flake8: F811 redefinition of unused 'test_drop_partition_with_purge' from line 
493


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@518
PS22, Line 518: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@646
PS22, Line 646: t
flake8: F821 undefined name 'test_create_alter_bulk_partition'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@648
PS22, Line 648: f
flake8: F821 undefined name 'fq_tbl_name'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@650
PS22, Line 650: @
flake8: F811 redefinition of unused 'test_create_alter_bulk_partition' from 
line 644


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@695
PS22, Line 695: t
flake8: F821 undefined name 'test_alter_table_set_fileformat'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@697
PS22, Line 697: @
flake8: F811 redefinition of unused 'test_alter_table_set_fileformat' from line 
693


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@721
PS22, Line 721: t
flake8: F821 undefined name 'test_alter_table_create_many_partitions'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@723
PS22, Line 723: @
flake8: F811 redefinition of unused 'test_alter_table_create_many_partitions' 
from line 720


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@745
PS22, Line 745: t
flake8: F821 undefined name 'test_create_alter_tbl_properties'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@747
PS22, Line 747: @
flake8: F811 redefinition of unused 'test_create_alter_tbl_properties' from 
line 744


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@805
PS22, Line 805: t
flake8: F821 undefined name 'test_alter_tbl_properties_reload'


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl.py@807
PS22, Line 807: @
flake8: F811 redefinition of unused 'test_alter_tbl_properties_reload' from 
line 804


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:

http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_ddl_base.py@132
PS22, Line 132: d
flake8: E303 too many blank lines (2)


http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_event_processing.py
File tests/metadata/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/20367/22/tests/metadata/test_event_processing.py@375
PS22, Line 375: t
flake8: F821 undefined name 'tetarget_db_obj'



--
To view, visit http://gerrit.cloudera.org:8080/20367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf
Gerrit-Change-Number: 20367
Gerrit-PatchSet: 22
Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jan 2024 00:48:08 +0000
Gerrit-HasComments: Yes

Reply via email to