Sai Hemanth Gantasala has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20367 )

Change subject: IMPALA-10976: Sync db/table to latest HMS event for all DDL/DMLs
......................................................................


Patch Set 24:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/20367/21//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20367/21//COMMIT_MSG@27
PS21, Line 27: Set 'enable_sync_to_latest_event_on_ddls'to true to enable this
> I mean this paragraph is incomplete. This patch doesn't set this flag to tr
Ack


http://gerrit.cloudera.org:8080/#/c/20367/21/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/20367/21/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2676
PS21, Line 2676:         org.apache.hadoop.hive.metastore.api.Table msTbl = 
null;
> > When the table is reloaded and it is not a fullReload, then we need to se
Ack


http://gerrit.cloudera.org:8080/#/c/20367/23/tests/custom_cluster/test_sync_to_latest_hms_events.py
File tests/custom_cluster/test_sync_to_latest_hms_events.py:

http://gerrit.cloudera.org:8080/#/c/20367/23/tests/custom_cluster/test_sync_to_latest_hms_events.py@60
PS23, Line 60:     
TestDdlStatements.test_truncate_cleans_hdfs_files(self.client,
> Can we use TestDdlStatements.test_truncate_cleans_hdfs_files() directly?
Ack



--
To view, visit http://gerrit.cloudera.org:8080/20367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf
Gerrit-Change-Number: 20367
Gerrit-PatchSet: 24
Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jan 2024 22:19:05 +0000
Gerrit-HasComments: Yes

Reply via email to