Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10222 )
Change subject: Warn about Hadoop / Java version incompatibility ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh File testdata/bin/run-mini-dfs.sh: http://gerrit.cloudera.org:8080/#/c/10222/2/testdata/bin/run-mini-dfs.sh@42 PS2, Line 42: if [[ $? != 0 ]]; then : # Don't issue Java version warning when not running Hadoop 3. : [[ $IMPALA_MINICLUSTER_PROFILE != 3 ]] && exit 1 > Good idea. Should we remove the check here then? The impala-config.sh check would protect buildall.sh cases. It also protects any new checkouts using master. Any new session would be protected. I think this check would only catch a few other cases, so I would be comfortable removing it. -- To view, visit http://gerrit.cloudera.org:8080/10222 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib16feb406afec83fd2380308a5d24a2793d246fd Gerrit-Change-Number: 10222 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Apr 2018 21:44:19 +0000 Gerrit-HasComments: Yes
