Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20810 )
Change subject: WIP: Skip KRPC in local exchanges ...................................................................... Patch Set 11: (11 comments) http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-recvr.cc@343 PS11, Line 343: if (payload->rpc_context != nullptr) TRACE_TO(payload->rpc_context->trace(), "Enqueuing deferred RPC"); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-recvr.cc@493 PS11, Line 493: //TRACE_TO(rpc_context->trace(), "Failed to deserialize batch: $0", status.GetDetail()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-recvr.cc@648 PS11, Line 648: if (ctx->rpc_context != nullptr) TRACE_TO(ctx->rpc_context->trace(), "Batch queue is full"); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-recvr.cc@671 PS11, Line 671: if (ctx->rpc_context != nullptr) recvr_->deferred_rpc_tracker()->Release(ctx->rpc_context->GetTransferSize()); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-recvr.cc@676 PS11, Line 676: if (ctx->rpc_context != nullptr) DataStreamService::RespondRpc(status, ctx->response, ctx->rpc_context); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/krpc-data-stream-sender.cc@697 PS11, Line 697: RETURN_IF_ERROR(parent_->SerializeBatch(batch, serialization_batch->get(), !is_local_)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/local-row-batch-channel.h File be/src/runtime/local-row-batch-channel.h: http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/local-row-batch-channel.h@38 PS11, Line 38: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/local-row-batch-channel.cc File be/src/runtime/local-row-batch-channel.cc: http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/local-row-batch-channel.cc@50 PS11, Line 50: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/local-row-batch-channel.cc@98 PS11, Line 98: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/local-row-batch-channel.cc@120 PS11, Line 120: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20810/11/be/src/runtime/local-row-batch-channel.cc@190 PS11, Line 190: Status LocalRowBatchChannelManager::RegisterSender(RuntimeState* state, line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee16cd943d76d04874bce7f3959e74b4685adb6e Gerrit-Change-Number: 20810 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 20:50:04 +0000 Gerrit-HasComments: Yes
