Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20823 )
Change subject: IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution ...................................................................... IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution This patch modifies the partition specification updating mechanism to use an updated Iceberg API. The new API preserves the existing partition specification by, for instance, generating new field IDs for modified partitioning terms. Additionally, the new API incorporates transactional support, as a result, the conditional branching based on the 'needsTxn' criterion has been eliminated. For Iceberg V1 tables, the new method correctly adds VOID(*) partition transform for removed fields at updates, for V2 tables, the updated field could be reused, but their order remains when they are first introduced in the spec, these changes are reflected in the test changes. Tests: - modified already existing tests - added e2e tests for V1 and V2 tables Change-Id: I958107d08e50d7bd9044a57bd2fc02816414012d Reviewed-on: http://gerrit.cloudera.org:8080/20823 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpr.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/IcebergUtil.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-delete-partitioned.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test M tests/query_test/test_iceberg.py 8 files changed, 226 insertions(+), 55 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I958107d08e50d7bd9044a57bd2fc02816414012d Gerrit-Change-Number: 20823 Gerrit-PatchSet: 8 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
