Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20486 )
Change subject: IMPALA-12356: Fix first ALTER_PARTITION event from Hive could be treated as self event ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/20486/16/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/20486/16/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@762 PS16, Line 762: private long lastRefreshEventId_; HdfsPartition instances are immutable. We should keep the 'final' keyword and update this using HdfsPartition.Builder. http://gerrit.cloudera.org:8080/#/c/20486/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20486/16/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a6820 PS16, Line 6820: : : Please keep using the original way to update the partition, i.e. using HdfsPartition.Builder. -- To view, visit http://gerrit.cloudera.org:8080/20486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3 Gerrit-Change-Number: 20486 Gerrit-PatchSet: 16 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 05:13:22 +0000 Gerrit-HasComments: Yes
