Zinway has posted comments on this change. ( http://gerrit.cloudera.org:8080/20834 )
Change subject: IMPALA-12665: Adjust complete_micro_batch_ length to new scratch_batch_->capacity after ScratchTupleBatch::Reset ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20834/2/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20834/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@2367 PS2, Line 2367: complete_micro_batch_.AdjustLength(scratch_batch_->capacity); > Let's add a DCHECK to verify that. Done -- To view, visit http://gerrit.cloudera.org:8080/20834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I966ff10ba734ed8b1b61325486de0dfcc7b58e4d Gerrit-Change-Number: 20834 Gerrit-PatchSet: 2 Gerrit-Owner: Zinway <zinway....@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Zinway <zinway....@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 03:51:16 +0000 Gerrit-HasComments: Yes
