Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20877 )
Change subject: IMPALA-12687: Fix key conflicts in tracking in-flight catalog operations ...................................................................... IMPALA-12687: Fix key conflicts in tracking in-flight catalog operations In-flight catalog operations are tracked in a map using query id as the key. It's ok since catalog clients use 0 as the timeout by default (see --catalog_client_rpc_timeout_ms), i.e. catalog RPCs never timeout, which means each query will have at most one in-flight catalog RPC at a time. However, in case catalog_client_rpc_timeout_ms is set to non-zero, impalad could retry the catalog RPC when it's considered timed out. That causes several in-flight catalog operations coming from the same query (so using the same query-id as the map key). To fix the key conflicts, this patch use the pair of (queryId, threadId) as the key of the in-flight operations map. 'threadId' comes from the thrift thread that handles the RPC so it's unique across different retries. Tests: - Add custom-cluster test to verify all retries are shown in the /operations page. Change-Id: Icd94ac7532fe7f3d68028c2da82298037be706c4 Reviewed-on: http://gerrit.cloudera.org:8080/20877 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java M tests/custom_cluster/test_web_pages.py 2 files changed, 136 insertions(+), 49 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icd94ac7532fe7f3d68028c2da82298037be706c4 Gerrit-Change-Number: 20877 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
