Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20876 )
Change subject: IMPALA-12566: Fix RpcMgrKerberizedTest on RedHat 8 ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20876/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20876/1//COMMIT_MSG@18 PS1, Line 18: During : negotiation, Kudu RPC will call GetFQDN to retrieve the FQDN > In this context, I guess Impala might benefit by cherry-picking this patch: That would likely be a performance optimization, but not actually impact this change. I've filed https://issues.apache.org/jira/browse/IMPALA-12707. http://gerrit.cloudera.org:8080/#/c/20876/1//COMMIT_MSG@24 PS1, Line 24: This is consistent > nit: there is a manual page for /etc/hosts itself; it can be found at list Ack http://gerrit.cloudera.org:8080/#/c/20876/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/20876/1/bin/bootstrap_system.sh@458 PS1, Line 458: $(hostname > nit: referring to https://man7.org/linux/man-pages/man1/hostname.1.html mig Done -- To view, visit http://gerrit.cloudera.org:8080/20876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb24f9faec766e388d793408aedecdc92107185 Gerrit-Change-Number: 20876 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 17:18:30 +0000 Gerrit-HasComments: Yes
