Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20482 )
Change subject: IMPALA-12431: Support reading compressed JSON file ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/20482/10/testdata/workloads/tpch/tpch_pairwise.csv File testdata/workloads/tpch/tpch_pairwise.csv: http://gerrit.cloudera.org:8080/#/c/20482/10/testdata/workloads/tpch/tpch_pairwise.csv@19 PS10, Line 19: file_format: json, dataset: tpch, compression_codec: none, compression_type: none > Shouldn't we remove the line of json/none? It looks like the uncompressed TPCH JSON tables also take up a lot of space. In this case, I think testing only the compressed JSON tables should be sufficient. Therefore, I have removed the uncompressed TPCH JSON tables. -- To view, visit http://gerrit.cloudera.org:8080/20482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2471855d97d4cdd51363b321055e6b06aa6d81e8 Gerrit-Change-Number: 20482 Gerrit-PatchSet: 10 Gerrit-Owner: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 03:19:45 +0000 Gerrit-HasComments: Yes
