Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20890 )
Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata ...................................................................... Patch Set 3: (1 comment) Hi Zihao Ye, thank you for catching and fixing this issue. The change looks good to me and can +2 after a small commit message change. http://gerrit.cloudera.org:8080/#/c/20890/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20890/3//COMMIT_MSG@12 PS3, Line 12: On the Impala project we usually add a short: "Tests" or "Testing" section to the commit message to highlight how the testing was done. In this case a simple: ``` Testing: - Added E2E test to cover this case ``` would suffice in my opinion. -- To view, visit http://gerrit.cloudera.org:8080/20890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843 Gerrit-Change-Number: 20890 Gerrit-PatchSet: 3 Gerrit-Owner: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Mon, 15 Jan 2024 10:20:34 +0000 Gerrit-HasComments: Yes
