Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10186 )
Change subject: IMPALA-6920: fix inconsistencies with scanner thread tokens ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10186/3/be/src/runtime/thread-resource-mgr.h File be/src/runtime/thread-resource-mgr.h: http://gerrit.cloudera.org:8080/#/c/10186/3/be/src/runtime/thread-resource-mgr.h@99 PS3, Line 99: > nit: extra space - several copy pasted comments contain double spaces, so t Yeah a lot of old comments have this but we standardised on not doing this. I was actually taught to do this myself when I initially learned to type so it doesn't look wrong to me. Fixed the method comments. http://gerrit.cloudera.org:8080/#/c/10186/3/be/src/runtime/thread-resource-mgr.h@189 PS3, Line 189: Set to NULL when unregistered. > Is there a reason behind this? Seems to be an object pool heritage, where R It's useful to assert that the resource pool was unregistered (it goes along with the DCHECK in the destructor). http://gerrit.cloudera.org:8080/#/c/10186/3/be/src/runtime/thread-resource-mgr.cc File be/src/runtime/thread-resource-mgr.cc: http://gerrit.cloudera.org:8080/#/c/10186/3/be/src/runtime/thread-resource-mgr.cc@55 PS3, Line 55: DCHECK(pools_.find(pool.get()) == pools_.end()); > Is this DCHECK still useful after removing object caching? Yeah it isn't really very useful. http://gerrit.cloudera.org:8080/#/c/10186/3/be/src/runtime/thread-resource-mgr.cc@133 PS3, Line 133: not > nit: double not Done -- To view, visit http://gerrit.cloudera.org:8080/10186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16d31d72441aff7293759281d0248e641df43704 Gerrit-Change-Number: 10186 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Apr 2018 17:59:41 +0000 Gerrit-HasComments: Yes
