Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 )
Change subject: IMPALA-12503: Support date data type for predicates for external data source table ...................................................................... Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/20915/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20915/4//COMMIT_MSG@15 PS4, Line 15: '=', '>', '<', Did you try "!=", ">=" and "<=" operators? Add new test cases with date in where conditions. http://gerrit.cloudera.org:8080/#/c/20915/4//COMMIT_MSG@17 PS4, Line 17: postgres and mysql Also need to add test cases for impala-to-impala: testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables.test http://gerrit.cloudera.org:8080/#/c/20915/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/20915/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@38 PS4, Line 38: import org.apache.impala.analysis.DateLiteral; Move this line up to line #32 to keep alphabet order http://gerrit.cloudera.org:8080/#/c/20915/4/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/20915/4/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@178 PS4, Line 178: @Override nit: add a function description http://gerrit.cloudera.org:8080/#/c/20915/4/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@181 PS4, Line 181: nit: remove extra space http://gerrit.cloudera.org:8080/#/c/20915/4/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@182 PS4, Line 182: 24 * 60 * 60 * 1000 nit: define a constant variable MILLI_SECONDS_PER_DAY http://gerrit.cloudera.org:8080/#/c/20915/4/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/util/QueryConditionUtil.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/util/QueryConditionUtil.java: http://gerrit.cloudera.org:8080/#/c/20915/4/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/util/QueryConditionUtil.java@87 PS4, Line 87: nit: remove two spaces http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/bin/load-ext-data-sources.sh File testdata/bin/load-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/bin/load-ext-data-sources.sh@45 PS4, Line 45: date nit: upper case to keep consistent http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/bin/load-ext-data-sources.sh@65 PS4, Line 65: date, nit: upper case to keep consistent http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test File testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test: http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test@120 PS4, Line 120: nit: remove extra space http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@120 PS4, Line 120: nit: remove extra space http://gerrit.cloudera.org:8080/#/c/20915/4/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@135 PS4, Line 135: nit: remove extra space -- To view, visit http://gerrit.cloudera.org:8080/20915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf13cbefaad812a0f78755c5791d82b24a3395e4 Gerrit-Change-Number: 20915 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 23:26:45 +0000 Gerrit-HasComments: Yes
