Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20874 )
Change subject: Addendum: IMPALA-12584: Enable strict data file access by default ...................................................................... Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/20874/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20874/10//COMMIT_MSG@11 PS10, Line 11: > nit: no space Done http://gerrit.cloudera.org:8080/#/c/20874/10//COMMIT_MSG@14 PS10, Line 14: to make the creation of 'iceberg_multiple_storage_locations' table > You could mention that during data loading we disable the location check. Done http://gerrit.cloudera.org:8080/#/c/20874/10/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/20874/10/be/src/util/backend-gflag-util.cc@447 PS10, Line 447: > nit: indentation is off Done http://gerrit.cloudera.org:8080/#/c/20874/10/fe/src/main/java/org/apache/impala/service/BackendConfig.java File fe/src/main/java/org/apache/impala/service/BackendConfig.java: http://gerrit.cloudera.org:8080/#/c/20874/10/fe/src/main/java/org/apache/impala/service/BackendConfig.java@435 PS10, Line 435: > nit: please add empty line before this Done http://gerrit.cloudera.org:8080/#/c/20874/10/tests/custom_cluster/test_iceberg_strict_data.py File tests/custom_cluster/test_iceberg_strict_data.py: http://gerrit.cloudera.org:8080/#/c/20874/10/tests/custom_cluster/test_iceberg_strict_data.py@55 PS10, Line 55: > nit: fits earlier line Done -- To view, visit http://gerrit.cloudera.org:8080/20874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifec84c86132a8a44d7e161006dcf51be2e7c7e57 Gerrit-Change-Number: 20874 Gerrit-PatchSet: 11 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Jan 2024 15:13:26 +0000 Gerrit-HasComments: Yes
