Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 )
Change subject: IMPALA-6522: [DOCS] Document Decimal V2 ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@539 PS10, Line 539: OUBLE DOUBLE and FLOAT http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@540 PS10, Line 540: error returns. Maybe add the following. The reasoning is that the range of the floating point types is much wider than the range of the DECIMAL, so not every FLOAT or DOUBLE can be converted to a DECIMAL. However, every DECIMAL can be converted to a double or float with a loss of precision, which is why we allow implicit casting in this case. This is somewhat dangerous, but we made this design choice to match the behavior of other SQL engines. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@545 PS10, Line 545: Add this: We do not allow this because calculations involving decimals are meant to be precise, so we are strict and require explicit casts. However, if an approximate type like FLOAT is involved, then our behavior is less strict. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Apr 2018 21:59:45 +0000 Gerrit-HasComments: Yes
