Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20867 )
Change subject: IMPALA-12688: Support JSON profile imports for visualizing query timeline in webUI ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/20867/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20867/2//COMMIT_MSG@12 PS2, Line 12: imported Should we allow user to select multiple json files by holding Shift key? nit: wrap around long line http://gerrit.cloudera.org:8080/#/c/20867/2//COMMIT_MSG@15 PS2, Line 15: browser's nit: wrap around long line http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@28 PS2, Line 28: This page lists all running queries, plus any completed queries that are : archived in memory need to reword to reflect the imported queries http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@305 PS2, Line 305: /query_timeline?query_id=${query.id} There are interference between 'imported queries' and 'Last 100 Completed Queries" if one query is listed on both sections. This can be re-produced by exporting profile file of one completed query, then importing the profile so that the query is listed on both sections. When clicking the query link in 'imported queries' section, the timeline tab shows nothing sometimes. http://gerrit.cloudera.org:8080/#/c/20867/2/www/query_plan_text.tmpl File www/query_plan_text.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/2/www/query_plan_text.tmpl@33 PS2, Line 33: "Query", "Timeline", "Text plan" Do you plan to add "Summary" and "Profile" tabs? -- To view, visit http://gerrit.cloudera.org:8080/20867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife6eb59bf2030fd19fc92aaf134eb51c609e04d0 Gerrit-Change-Number: 20867 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 05:19:32 +0000 Gerrit-HasComments: Yes
