Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20804 )
Change subject: IMPALA-12631: Improve count star performance for parquet scans ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/20804/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20804/12//COMMIT_MSG@16 PS12, Line 16: A new query option parquet_count_star_use_file_metadata is added for : forward compatibility. Its default value is true, if any inconsistency : between FileMetaData.num_rows and RowGroup.num_rows is found, we can : set it to false to get same results as old versions. > Yeah. I adjusted it to sum RowGroup.num_rows in PS13 and got the same perfo Yes, I think now it makes sense to remove the query option. -- To view, visit http://gerrit.cloudera.org:8080/20804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9cd2448fe51a420d4559d0cc861c4d30822f4fd Gerrit-Change-Number: 20804 Gerrit-PatchSet: 12 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 17:48:15 +0000 Gerrit-HasComments: Yes
