Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20367 )

Change subject: IMPALA-10976: Sync db/table to latest HMS event for all DDL/DMLs
......................................................................


Patch Set 31:

(16 comments)

http://gerrit.cloudera.org:8080/#/c/20367/31/tests/custom_cluster/test_sync_to_latest_hms_events.py
File tests/custom_cluster/test_sync_to_latest_hms_events.py:

http://gerrit.cloudera.org:8080/#/c/20367/31/tests/custom_cluster/test_sync_to_latest_hms_events.py@27
PS31, Line 27: from tests.util.filesystem_utils import (
flake8: F401 'tests.util.filesystem_utils.IS_HDFS' imported but unused


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py
File tests/metadata/test_common_ddl.py:

http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py@33
PS31, Line 33: def get_trash_path(bucket, path):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py@35
PS31, Line 35: g
flake8: F821 undefined name 'get_fs_path'


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py@36
PS31, Line 36: W
flake8: F821 undefined name 'WAREHOUSE_PREFIX'


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py@40
PS31, Line 40: class TestCommonDdl(TestDdlBase):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py@78
PS31, Line 78: y
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py@149
PS31, Line 149: ;
flake8: E703 statement ends with a semicolon


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_common_ddl.py@318
PS31, Line 318:
flake8: W292 no newline at end of file


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_ddl.py@61
PS31, Line 61: class TestDdlStatements(TestCommonDdl, TestDdlBase):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_ddl.py@154
PS31, Line 154: t
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing.py
File tests/metadata/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing.py@29
PS31, Line 29: T
flake8: F821 undefined name 'TestEventProcessingBase'


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing.py@39
PS31, Line 39: T
flake8: F821 undefined name 'TestEventProcessingBase'


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing.py@45
PS31, Line 45: T
flake8: F821 undefined name 'TestEventProcessingBase'


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing.py@75
PS31, Line 75: T
flake8: F821 undefined name 'TestEventProcessingBase'


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing_base.py
File tests/metadata/test_event_processing_base.py:

http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing_base.py@23
PS31, Line 23: @SkipIfFS.hive
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20367/31/tests/metadata/test_event_processing_base.py@345
PS31, Line 345: t
flake8: E111 indentation is not a multiple of 2



--
To view, visit http://gerrit.cloudera.org:8080/20367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf
Gerrit-Change-Number: 20367
Gerrit-PatchSet: 31
Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Jan 2024 01:55:09 +0000
Gerrit-HasComments: Yes

Reply via email to