Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20965 )
Change subject: IMPALA-12762: Fix cmake error in package building ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks for fixing this so quickly! http://gerrit.cloudera.org:8080/#/c/20965/1/bin/jenkins/build-all-flag-combinations.sh File bin/jenkins/build-all-flag-combinations.sh: http://gerrit.cloudera.org:8080/#/c/20965/1/bin/jenkins/build-all-flag-combinations.sh@42 PS1, Line 42: skiptests Let's change this to "notests" so new changes won't break the build again. http://gerrit.cloudera.org:8080/#/c/20965/1/bin/jenkins/build-all-flag-combinations.sh@50 PS1, Line 50: skiptests Let's change this to "notests" as well. -- To view, visit http://gerrit.cloudera.org:8080/20965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice0cbb0671d915f997fa74217521a82be164ae57 Gerrit-Change-Number: 20965 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Mon, 29 Jan 2024 13:07:29 +0000 Gerrit-HasComments: Yes
