Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20915 )

Change subject: IMPALA-12503: Support date data type for predicates for 
external data source table
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20915/10/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java
File 
java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java:

http://gerrit.cloudera.org:8080/#/c/20915/10/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@219
PS10, Line 219: dateCol+ 1
Need to set the time zone for the formatter as 'UDC' to avoid +1:
  formatter.setTimeZone(TimeZone.getTimeZone("UDC"));



--
To view, visit http://gerrit.cloudera.org:8080/20915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf13cbefaad812a0f78755c5791d82b24a3395e4
Gerrit-Change-Number: 20915
Gerrit-PatchSet: 10
Gerrit-Owner: gaurav singh <gsi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Jan 2024 00:51:42 +0000
Gerrit-HasComments: Yes

Reply via email to