gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 )
Change subject: IMPALA-12503: Support date data type for predicates for external data source table ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/20915/12/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/20915/12/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java@36 PS12, Line 36: getDateString(int dateCol); > rename function and input parameter as getDateString(int dateVal) Done http://gerrit.cloudera.org:8080/#/c/20915/12/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/20915/12/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@218 PS12, Line 218: getDateString(int dateCol) > rename function and input parameter as getDateString(int dateVal) Done http://gerrit.cloudera.org:8080/#/c/20915/12/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test: http://gerrit.cloudera.org:8080/#/c/20915/12/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@49 PS12, Line 49: ---- QUERY : # Create external JDBC DataSource table : DROP TABLE IF EXISTS alltypes_jdbc_datasource_2; : CREATE TABLE alltypes_jdbc_datasource_2 ( : id INT, : bool_col BOOLEAN, : tinyint_col TINYINT, : smallint_col SMALLINT, : int_col INT, : bigint_col BIGINT, : float_col FLOAT, : double_col DOUBLE, : date_col DATE, : string_col STRING, : timestamp_col TIMESTAMP) : PRODUCED BY DATA SOURCE TestJdbcDataSource( : '{"database.type":"IMPALA", : "jdbc.url":"jdbc:impala://$INTERNAL_LISTEN_HOST:21050/functional", : "jdbc.auth":"AuthMech=0", : "jdbc.driver":"com.cloudera.impala.jdbc.Driver", : "driver.url":"$FILESYSTEM_PREFIX/test-warehouse/data-sources/jdbc-drivers/ImpalaJDBC42.jar", : "dbcp.username":"impala", : "dbcp.password":"cloudera", : "table":"alltypes_with_date"}'); : ---- RESULTS : 'Table has been created.' : ==== > remove this table since it is not used Done http://gerrit.cloudera.org:8080/#/c/20915/12/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/20915/12/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@185 PS12, Line 185: 2009-01-09 > nit: just curious why the values of date columns in MySQL database are diff My guess would be that the engines have different data structures for data representation ? -- To view, visit http://gerrit.cloudera.org:8080/20915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf13cbefaad812a0f78755c5791d82b24a3395e4 Gerrit-Change-Number: 20915 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Feb 2024 19:10:45 +0000 Gerrit-HasComments: Yes