Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 )
Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Thank you! Everything else looks good to me. http://gerrit.cloudera.org:8080/#/c/20926/12/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/20926/12/be/src/exprs/expr-test.cc@11111 PS12, Line 11111: // Tests *trim() with UTF-8 characters in UTF8_MODE. Done -- To view, visit http://gerrit.cloudera.org:8080/20926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cfaffd71009f16eae75910af835bd2a34410856 Gerrit-Change-Number: 20926 Gerrit-PatchSet: 12 Gerrit-Owner: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Fri, 02 Feb 2024 05:50:13 +0000 Gerrit-HasComments: Yes
