Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20263 )
Change subject: WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20263/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20263/7//COMMIT_MSG@9 PS7, Line 9: independent linux packaging related content to package/CMakeLists.txt. > Could you share the benifits of doing this? the main reason is that I want to make the cmake file structure more clearly :) -- To view, visit http://gerrit.cloudera.org:8080/20263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 20263 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Sat, 03 Feb 2024 10:50:58 +0000 Gerrit-HasComments: Yes
