Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 )
Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20922/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/20922/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1758 PS6, Line 1758: analyzer.getQueryOptions().getReplica_preference().equals( : TReplicaPreference.REMOTE) ? : analyzer.numExecutorsForPlanning() : > Is this only required by the test or does it also fix some bugs? This is test only (planner_testcase_mode==true). HDFS minicluster only have 3 datanodes. Without this change, even if we declare more executors in PlannerTest, it will only plan ScanNodes in 3 executors (due to line 1750-1756). -- To view, visit http://gerrit.cloudera.org:8080/20922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaffddd70c2da8376ca6c40f65606bbac46c34de7 Gerrit-Change-Number: 20922 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Sun, 04 Feb 2024 16:32:06 +0000 Gerrit-HasComments: Yes
