Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21001
Change subject: IMPALA-11568: Fix SamplingTimeSeriesCounter not correctly cleared ...................................................................... IMPALA-11568: Fix SamplingTimeSeriesCounter not correctly cleared TimeSeriesCounters are scheduled in PeriodicCounterUpdater at the time when they are added. TimeSeriesCounterToJsonTest stops and clears them to avoid the update thread interfere with the rest of the test. However, the samples in SamplingTimeSeriesCounter are not cleared since it doesn't implement the Clear() method of TimeSeriesCounter. This leads to non-determined results depend on when the counter is stopped. This patch adds the Clear() method for SamplingTimeSeriesCounter to clear the samples. A Reset() method in StreamingSampler is added for this purpose. Test: - Ran TimeSeriesCounterToJsonTest 1500 times. Change-Id: I8bc2c94ad96899522b288708fcaf7413d4b99fa1 --- M be/src/util/runtime-profile-counters.h M be/src/util/runtime-profile-test.cc M be/src/util/runtime-profile.cc M be/src/util/streaming-sampler.h 4 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/21001/1 -- To view, visit http://gerrit.cloudera.org:8080/21001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8bc2c94ad96899522b288708fcaf7413d4b99fa1 Gerrit-Change-Number: 21001 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
