Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10244 )
Change subject: Warn about Hadoop / Java version incompatibility ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/10244/1/bin/impala-config.sh@224 PS1, Line 224: : # Check for minimum required Java version : # Only issue Java version warning when running Java 7. : if $JAVA -version 2>&1 | grep -q 'java version "1.7'; then : cat << EOF : : Your development environment is configured for Hadoop 3 and Java 7. Hadoop 3 requires at : least Java 8. Your JAVA binary currently points to $JAVA : and reports the following version: : : EOF : $JAVA -version : echo : fi If we are warning rather than exiting, then it would be useful to have this be the last thing that a user would see. I think we do a bunch of prints down below that would push this off the terminal screen. -- To view, visit http://gerrit.cloudera.org:8080/10244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d8b505cf045eeb562d16ce4ce09da0712dc03eb Gerrit-Change-Number: 10244 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Apr 2018 18:38:02 +0000 Gerrit-HasComments: Yes
