Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20999 )
Change subject: IMPALA-12787: Concurrent DELETE and UPDATE operations on Iceberg tables can be problematic ...................................................................... Patch Set 2: (1 comment) Thanks for the comment! http://gerrit.cloudera.org:8080/#/c/20999/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20999/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@375 PS2, Line 375: rowDelta.validateNoConflictingDataFiles(); > This is a complete nit but is it more iceberg-style to chain the calls? Her Personally I like method chaining for Builder classes, in other cases I find it a bit strange. In general, I think what should matter is the Impala coding style, not the coding style of the library we are using. Impala's Java coding style doesn't say too much about anything though. I can switch to chaining if you like, I don't really have a strong opinion about this. -- To view, visit http://gerrit.cloudera.org:8080/20999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e581ea17fa8f6ccd9c87aaad1281bb694079f6e Gerrit-Change-Number: 20999 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Feb 2024 13:04:56 +0000 Gerrit-HasComments: Yes
