Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 )
Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/20204/13/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20204/13/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@132 PS13, Line 132: private long nit: Is this require mutability? Can this changed to "private final long", initialized in constructor? http://gerrit.cloudera.org:8080/#/c/20204/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/20204/13/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@649 PS13, Line 649: public static long getSnapshotId(FeIcebergTable table, TimeTravelSpec timeTravelSpec) { : if (timeTravelSpec == null) return table.snapshotId(); : TableScan scan = createScanAsOf(table, timeTravelSpec); : return scan.snapshot().snapshotId(); : } nit: Add precondition before returning to verify that snapshot id is always positive integer. I understand Iceberg spec says snapshot id is a required field, so it must not be a null. https://iceberg.apache.org/spec/#snapshots -- To view, visit http://gerrit.cloudera.org:8080/20204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee0b4967429ea733729ad8e44df32e3b24b88525 Gerrit-Change-Number: 20204 Gerrit-PatchSet: 13 Gerrit-Owner: Gergely Fürnstáhl <g.furnst...@gmail.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <g.furnst...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Feb 2024 16:31:11 +0000 Gerrit-HasComments: Yes
