Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21005 )
Change subject: IMPALA-12790: Fix overestimation in ScanNode.getInputCardinality ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21005/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/21005/1/fe/src/main/java/org/apache/impala/planner/ScanNode.java@335 PS1, Line 335: capInputCardinality > Probably a name like capInputCardinalityWithLimit would be clearer? Done http://gerrit.cloudera.org:8080/#/c/21005/1/fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java File fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java: http://gerrit.cloudera.org:8080/#/c/21005/1/fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java@59 PS1, Line 59: maxRowsProcessed_ = Math.max(maxRowsProcessed_, numRows); > I agree, the HdfsScanNode seems pretty consistent in trying to always come removed this in ps2. With this removal, we see different behavior in small-query-opt.test for this test cases: select * from functional.testtbl; select * from functional.testtbl limit 1000; The former is distributed while the latter runs in coordinator only. http://gerrit.cloudera.org:8080/#/c/21005/1/testdata/workloads/functional-planner/queries/PlannerTest/small-query-opt.test File testdata/workloads/functional-planner/queries/PlannerTest/small-query-opt.test: http://gerrit.cloudera.org:8080/#/c/21005/1/testdata/workloads/functional-planner/queries/PlannerTest/small-query-opt.test@545 PS1, Line 545: > nit, here and in next 3 queries: "has no stats" Done -- To view, visit http://gerrit.cloudera.org:8080/21005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc5b39a7684fb8748185349d0b80baf8dcd6b126 Gerrit-Change-Number: 21005 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Feb 2024 18:50:25 +0000 Gerrit-HasComments: Yes
